fix: envelope file viewer fallback#6268
Merged
vitormattos merged 2 commits intomainfrom Dec 30, 2025
Merged
Conversation
- Move URL generation outside conditional to avoid duplication - Add fallback to window.open() when OCA.Viewer is unavailable - Simplify reference from window.OCA to OCA for consistency - Ensures PDFs can be opened directly if Viewer app fails Signed-off-by: Vitor Mattos <[email protected]>
- Move URL generation outside conditional to avoid code duplication - Ensures URL is generated once and reused for both viewer and fallback - Maintains fallback to window.open() when OCA.Viewer is unavailable Signed-off-by: Vitor Mattos <[email protected]>
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.